Skip to content

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Jan 17, 2026

Proposed changes (including videos or screenshots)

It uses named subcomponents for Message from @rocket.chat/fuselage.

This pull request focuses on updating the usage of message-related components throughout the codebase to use the new, individual @rocket.chat/fuselage message subcomponents directly, rather than accessing them as properties of the main Message component. This change improves clarity, consistency, and maintainability by making component usage more explicit and aligning with the latest best practices for the Fuselage UI library.

The most important changes include:

Refactoring to Use Direct Message Subcomponents:

  • Replaced all usages of Message.[Subcomponent] (such as Message.LeftContainer, Message.Container, etc.) with direct imports and usage of the corresponding subcomponents (e.g., MessageLeftContainer, MessageContainer, etc.) in the following files:
    • apps/meteor/client/views/admin/moderation/helpers/ContextMessage.tsx [1] [2] [3]
    • apps/meteor/client/views/room/contextualBar/Discussions/components/DiscussionsListItem.tsx [1] [2]
    • apps/meteor/client/views/room/contextualBar/Threads/components/ThreadListMessage.tsx [1] [2]
    • apps/meteor/client/views/room/contextualBar/VideoConference/VideoConfList/VideoConfListItem.tsx [1] [2] [3]
    • apps/uikit-playground/src/Components/Preview/Display/Surface/MessageSurface.tsx
    • packages/fuselage-ui-kit/src/stories/Message.stories.tsx [1] [2] [3] [4]

Component Naming Consistency and Clarity:

  • Updated code to use the new naming convention for message subcomponents, such as MessageLeftContainer, MessageContainer, MessageHeader, MessageName, MessageTimestamp, MessageBody, MessageToolbarWrapper, MessageToolbar, and MessageToolbarItem for better readability and maintainability. [1] [2] [3] [4] [5] [6]

Special Case for Highlight Component:

  • Updated the ChannelMentionElement to use the new MessageHighlight component directly instead of Message.Highlight. [1] [2]

These changes ensure that the codebase is up-to-date with the latest Fuselage API and improve overall code clarity.

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Refactor
    • Updated internal component architecture and structure to improve code organization and maintainability across multiple application modules.

✏️ Tip: You can customize this high-level summary in your review settings.

@tassoevan tassoevan added this to the 8.1.0 milestone Jan 17, 2026
@tassoevan tassoevan requested a review from a team as a code owner January 17, 2026 20:20
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jan 17, 2026

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jan 17, 2026

⚠️ No Changeset found

Latest commit: 372a676

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 17, 2026

Walkthrough

This PR updates component usage across 8 files to leverage new granular Message subcomponent exports from @rocket.chat/fuselage, replacing nested property access (e.g., Message.Divider, Message.Container) with distinct named components (e.g., MessageDivider, MessageContainer) throughout the codebase.

Changes

Cohort / File(s) Summary
Admin & Moderation Views
apps/meteor/client/views/admin/moderation/helpers/ContextMessage.tsx
Replaced Message.* nested properties with distinct components: MessageDivider, MessageLeftContainer, MessageContainer, MessageHeader, MessageTimestamp, MessageRole, MessageBody, and MessageToolbar. Adjusted JSX structure and nesting accordingly.
Room Context Features
apps/meteor/client/views/room/contextualBar/Discussions/components/DiscussionsListItem.tsx, apps/meteor/client/views/room/contextualBar/Threads/components/ThreadListMessage.tsx, apps/meteor/client/views/room/contextualBar/VideoConference/VideoConfList/VideoConfListItem.tsx
Refactored to use explicit message subcomponents (MessageLeftContainer, MessageContainer, MessageHeader, MessageName, MessageTimestamp, MessageBody, etc.) replacing legacy Message.* wrappers. Updated JSX hierarchy while preserving conditional rendering and layout behavior.
Gazzodown Mention Elements
packages/gazzodown/src/mentions/ChannelMentionElement.tsx, packages/gazzodown/src/mentions/UserMentionElement.tsx
Replaced Message.Highlight usage with MessageHighlight component in mention rendering logic. Updated imports and JSX tags; no behavioral changes.
Stories & Documentation
packages/fuselage-ui-kit/src/stories/Message.stories.tsx, packages/ui-video-conf/src/VideoConfMessage/VideoConfMessage.stories.tsx, apps/uikit-playground/src/Components/Preview/Display/Surface/MessageSurface.tsx
Updated story compositions to use granular message subcomponents instead of Message.* nested properties. Expanded import declarations to include individual components; content and structure preserved.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

  • ggazzo
  • gabriellsh

Poem

🐰 Components hop and reorganize,
No longer nested, they modularize!
From Message.Divider to MessageDivider bright,
Each subcomponent finds its own light.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main objective of the PR: refactoring the codebase to use named Fuselage message subcomponents instead of nested Message properties.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor/message-component-namespace

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

@codecov
Copy link

codecov bot commented Jan 17, 2026

Codecov Report

❌ Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.67%. Comparing base (f12402e) to head (372a676).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #38237   +/-   ##
========================================
  Coverage    70.67%   70.67%           
========================================
  Files         3136     3136           
  Lines       108592   108592           
  Branches     19552    19603   +51     
========================================
  Hits         76750    76750           
+ Misses       29838    29833    -5     
- Partials      2004     2009    +5     
Flag Coverage Δ
e2e 60.27% <ø> (-0.05%) ⬇️
e2e-api 47.97% <ø> (-0.13%) ⬇️
unit 71.77% <81.81%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2026

📦 Docker Image Size Report

➡️ Changes

Service Current Baseline Change Percent
sum of all images 0B 0B 0B
account-service 0B 0B 0B
authorization-service 0B 0B 0B
ddp-streamer-service 0B 0B 0B
omnichannel-transcript-service 0B 0B 0B
presence-service 0B 0B 0B
queue-worker-service 0B 0B 0B
rocketchat 0B 0B 0B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 23:27", "12/20 21:03", "12/22 18:54", "12/23 16:16", "12/24 19:38", "12/25 17:51", "12/26 13:18", "12/29 19:01", "12/30 20:52", "01/19 15:03 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.00]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "queue-worker-service" [0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
  line "rocketchat" [0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.00]
Loading

Statistics (last 30 days):

  • 📊 Average: 1.5GiB
  • ⬇️ Minimum: 1.4GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 0B
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-38237
  • Baseline: develop
  • Timestamp: 2026-01-19 15:03:21 UTC
  • Historical data points: 30

Updated: Mon, 19 Jan 2026 15:03:22 GMT

@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Jan 19, 2026
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 19, 2026
@kodiakhq kodiakhq bot merged commit 13fa8d1 into develop Jan 19, 2026
44 checks passed
@kodiakhq kodiakhq bot deleted the refactor/message-component-namespace branch January 19, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants