-
Notifications
You must be signed in to change notification settings - Fork 13k
refactor: Update Message component structure and imports for consistency
#38237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
WalkthroughThis PR updates component usage across 8 files to leverage new granular Message subcomponent exports from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 9 files
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #38237 +/- ##
========================================
Coverage 70.67% 70.67%
========================================
Files 3136 3136
Lines 108592 108592
Branches 19552 19603 +51
========================================
Hits 76750 76750
+ Misses 29838 29833 -5
- Partials 2004 2009 +5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
It uses named subcomponents for
Messagefrom@rocket.chat/fuselage.This pull request focuses on updating the usage of message-related components throughout the codebase to use the new, individual
@rocket.chat/fuselagemessage subcomponents directly, rather than accessing them as properties of the mainMessagecomponent. This change improves clarity, consistency, and maintainability by making component usage more explicit and aligning with the latest best practices for the Fuselage UI library.The most important changes include:
Refactoring to Use Direct Message Subcomponents:
Message.[Subcomponent](such asMessage.LeftContainer,Message.Container, etc.) with direct imports and usage of the corresponding subcomponents (e.g.,MessageLeftContainer,MessageContainer, etc.) in the following files:apps/meteor/client/views/admin/moderation/helpers/ContextMessage.tsx[1] [2] [3]apps/meteor/client/views/room/contextualBar/Discussions/components/DiscussionsListItem.tsx[1] [2]apps/meteor/client/views/room/contextualBar/Threads/components/ThreadListMessage.tsx[1] [2]apps/meteor/client/views/room/contextualBar/VideoConference/VideoConfList/VideoConfListItem.tsx[1] [2] [3]apps/uikit-playground/src/Components/Preview/Display/Surface/MessageSurface.tsxpackages/fuselage-ui-kit/src/stories/Message.stories.tsx[1] [2] [3] [4]Component Naming Consistency and Clarity:
MessageLeftContainer,MessageContainer,MessageHeader,MessageName,MessageTimestamp,MessageBody,MessageToolbarWrapper,MessageToolbar, andMessageToolbarItemfor better readability and maintainability. [1] [2] [3] [4] [5] [6]Special Case for Highlight Component:
ChannelMentionElementto use the newMessageHighlightcomponent directly instead ofMessage.Highlight. [1] [2]These changes ensure that the codebase is up-to-date with the latest Fuselage API and improve overall code clarity.
Issue(s)
Steps to test or reproduce
Further comments
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.